Skip to content

Fix not using configuration option in creating provisioning profile#306

Merged
anoworl merged 1 commit intomasterfrom
work/fix_configration_option_broken
Nov 1, 2022
Merged

Fix not using configuration option in creating provisioning profile#306
anoworl merged 1 commit intomasterfrom
work/fix_configration_option_broken

Conversation

@anoworl
Copy link
Copy Markdown
Contributor

@anoworl anoworl commented Oct 31, 2022 •
edited
Loading

I fixed not using configuration option in creating provisioning profile.

When

I had 3 build configrations in the build target.

  • Release
    • Bundle ID: net.anoworl.Test
  • Debug
    • Bundle ID: net.anoworl.Test
  • test
    • Bundle ID: net.anoworl.Test2 -> I want to build this!

Before

The app_identifier is net.anoworl.Test.

$ dg add-devices --configuration test
...
+-------------------------------------+---------------------+
|                 Summary for sigh 2.148.1                  |
+-------------------------------------+---------------------+
| adhoc                               | true                |
| app_identifier                      | net.anoworl.Test    |
...
[04:27:52]: Creating new provisioning profile for 'net.anoworl.Test' with name 'net.anoworl.Test AdHoc' for 'ios' platform
...

After

The app_identifier is net.anoworl.Test2.

$ dg add-devices --configuration test
+-------------------------------------+---------------------+
|                 Summary for sigh 2.148.1                  |
+-------------------------------------+---------------------+
| adhoc                               | true                |
| app_identifier                      | net.anoworl.Test2   |
...
[10:54:40]: Creating new provisioning profile for 'net.anoworl.Test2' with name 'net.anoworl.Test2 AdHoc' for 'ios' platform
...

@anoworl anoworl marked this pull request as ready for review November 1, 2022 01:57
@jmatsu jmatsu self-requested a review November 1, 2022 02:02
jmatsu
jmatsu approved these changes Nov 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jmatsu jmatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anoworl
Copy link
Copy Markdown
Contributor Author

anoworl commented Nov 1, 2022

thx!

@anoworl anoworl merged commit 9f92fb0 into master Nov 1, 2022
@anoworl anoworl deleted the work/fix_configration_option_broken branch November 1, 2022 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jmatsu jmatsu jmatsu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anoworl @jmatsu